Container transition to MANIFEST_PULLED state should happen after network pause container reaches RESOURCES_PROVISIONED state #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
force-pushed
the
docker-pause-container-test
branch
2 times, most recently
from
437ed1f to
265eb4f
Compare
amogh09
changed the title
amogh09
changed the title
…network pause container is RUNNING
amogh09
force-pushed
the
docker-pause-container-test
branch
from
57199c0 to
fad3fc7
Compare
Yiyuanzzz
previously approved these changes
Aug 15, 2024
singholt
previously approved these changes
Aug 15, 2024
singholt
approved these changes
Aug 15, 2024
Yiyuanzzz
approved these changes
Aug 15, 2024
harishxr
pushed a commit
that referenced
this pull request
Aug 18, 2024
* Revert "Expose FaultInjection status in TaskResponse (#4285)" This reverts commit fd3693c. * Revert "Implementing network blackhole port handler" This reverts commit 177dbd2. * Revert "TaskStopVerificationACKResponder integration tests (#4282)" This reverts commit d6fbc04. * Revert "Container transition to MANIFEST_PULLED state should happen after network pause container reaches RESOURCES_PROVISIONED state (#4286)" This reverts commit 6c7758d.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make awsvpc task containers' transition to MANIFEST_PULLED state depend on the network pause container reaching RESOURCES_PROVISIONED (RUNNING state for the pause container) state. This is because transition to MANIFEST_PULLED state may involve an image repository call which needs to be routed through the network pause container for some setups.
Also update existing task engine tests for awsvpc tasks to ensure that for an awsvpc task, any
DockerClientmethod calls that may call an image repository, happen after the network pause container has reached RESOURCES_PROVISIONED state. This should prevent similar bugs from happening in the future.Testing
Updated unit tests.
Ran an
awsvpcnetwork mode task and observed in Agent logs that the pause container reaches RESOURCES_PROVISIONED state before the task container transitions to MANIFEST_PULLED state.New tests cover the changes: yes
Description for the changelog
Does this PR include breaking model changes? If so, Have you added transformation functions?
Bugfix: AWSVPC task containers' transition to MANIFEST_PULLED state should depend on the network pause container reaching RESOURCES_PROVISIONED state.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.